-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pydantic to version 2.4 #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `pydantic-settings` as a new dependency * Replace nested `Config` class with `SettingsConfigDict` * Import Pydantic v2 `ValidationError` * Fix Pydantic v2 warnings by using `model_dump()` * Update tests to reflect Pydantic v2 changes * Replace Python 3.7 support with Python 3.11 * Write Python versions as strings in GHA workflows * Drop CI support for Python 3.11
Mandrenkov
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good! 🥳 Just a few minor tweaks before we can merge.
Mandrenkov
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @heltluke!
Co-authored-by: Mikhail Andrenkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
pydantic
2 comes with new features that one would like to take advantage of in various repos that import fromstrtawberryfields
and thexanadu-cloud-client
but is presently unable to due topydantic
being pinned to version1.8.2
here.Description of the Change:
Pins
pydantic
to version2.4
.Benefits:
Everyone can use the latest features of
pydantic
.Possible Drawbacks:
Not likely to be many/any.
Related GitHub Issues:
N/A