Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support search redirects to PennyLane.ai #47

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Mandrenkov
Copy link
Collaborator

@Mandrenkov Mandrenkov commented Oct 16, 2024

Context:

Search in Sphinx is, both functionally and aesthetically, lacking. This PR introduces a theme option (for the PennyLane Sphinx Theme) to redirect users from search.html to https://pennylane.ai/search (with the right query parameters).

It's worth noting that PennyLane Docs are not surfaced yet in PennyLane.ai search results but this will change soon.

Description of the Change:

  1. Added a theme option, search_on_pennylane_ai, which redirects users from search.html (i.e., after submitting a query using the search box in the LHS ToC) to https://pennylane.ai/search with the following query parameters:
    • contentType: Set to DOC.
    • q: Set to the query in the search box.
    • version: Set to stable, unless /latest/ is part of the current URL, in which case latest is used instead.

Benefits:

  1. PennyLane Docs users have easier access to a better search experience.

Possible Drawbacks:

None.

Related GitHub Issues:

None.


Verification:

See https://xanaduai-pennylane--67.com.readthedocs.build/projects/sphinx-theme/en/67/.

Merge Checklist:

  • PennyLane Docs are surfaced in PennyLane.ai search results.

@Mandrenkov Mandrenkov added the do not merge yet This pull request should not be merged (yet) label Oct 16, 2024
Mandrenkov added a commit to PennyLaneAI/pennylane-sphinx-theme that referenced this pull request Oct 16, 2024
@Mandrenkov Mandrenkov marked this pull request as ready for review October 16, 2024 16:19
Copy link
Contributor

@anthayes92 anthayes92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! 🚀

xanadu_sphinx_theme/search.html Show resolved Hide resolved
Copy link

@AndrewGardhouse AndrewGardhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet This pull request should not be merged (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants