-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support search redirects to PennyLane.ai #47
Open
Mandrenkov
wants to merge
12
commits into
master
Choose a base branch
from
sc-75207-pennylane-ai-search-redirect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandrenkov
added
the
do not merge yet
This pull request should not be merged (yet)
label
Oct 16, 2024
Mandrenkov
added a commit
to PennyLaneAI/pennylane-sphinx-theme
that referenced
this pull request
Oct 16, 2024
3 tasks
Co-authored-by: Andrew Gardhouse <[email protected]>
anthayes92
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! 🚀
AndrewGardhouse
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Search in Sphinx is, both functionally and aesthetically, lacking. This PR introduces a theme option (for the PennyLane Sphinx Theme) to redirect users from
search.html
to https://pennylane.ai/search (with the right query parameters).It's worth noting that PennyLane Docs are not surfaced yet in PennyLane.ai search results but this will change soon.
Description of the Change:
search_on_pennylane_ai
, which redirects users fromsearch.html
(i.e., after submitting a query using the search box in the LHS ToC) to https://pennylane.ai/search with the following query parameters:contentType
: Set toDOC
.q
: Set to the query in the search box.version
: Set tostable
, unless/latest/
is part of the current URL, in which caselatest
is used instead.Benefits:
Possible Drawbacks:
None.
Related GitHub Issues:
None.
Verification:
See https://xanaduai-pennylane--67.com.readthedocs.build/projects/sphinx-theme/en/67/.
Merge Checklist: