Update gem to work with omniauth-oauth2 1.8.0 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaedonfarrugia
commented
Jun 10, 2024
| s.add_dependency 'omniauth-oauth2', '~> 1.7.1' | ||
| spec.add_runtime_dependency 'jwt', '~> 2.0' | ||
| spec.add_runtime_dependency 'omniauth', '>= 2.0.0', '< 2.2.0' | ||
| spec.add_runtime_dependency 'omniauth-oauth2', '~> 1.8.0' |
There was a problem hiding this comment.
this dependency has been bumped to 1.8.0
jaedonfarrugia
commented
Jun 10, 2024
|
|
||
| def build_access_token | ||
| redirect_uri = request.params['redirect_uri'] || callback_url | ||
| authorization_code = request.params['code'] || JSON.parse(request.body.read)['code'] |
There was a problem hiding this comment.
this strategy has been updated to read the code from the request body
jaedonfarrugia
changed the title
authorization code was no longer working due to omniauth / omniauth-oauth2 updates, there were also conflicts with other gems using a later version of omniauth-oauth2 (1.8), meaning this gem could not be used in combination with google/microsoft strategies
|
It would be great if this could be merged ASAP - it is a rather overdue change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authentication flow was failing on authorization code step due to omniauth / omniauth-oauth2 updates
given the previous requirement to use omniauth-oauth2 1.7.0, this gem could not be used in combination with google/microsoft strategies which rely on versions above 1.8.0