Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pinned versions from requirements.txt #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmanecke
Copy link

It doesn't make sense to have pinned dependencies in requirements.txt file as this a demo app. Pinned versions can result in the problem we have now were dependencies are out of sync.

  • removed pinned version from flask-session and flask-oauthlib
    • if flask is left unpinned, then these should be too
  • removed pinned version for xero-python
    • the pin at 1.5.3 was very old, the package is up to v 7.0.1
    • checked against python 3.9 and above (all versions not EOL) and all work with latest xero-python (7.0.1)

Updates to the README.md file increase likelihood of success following the instructions

  • add step to upgrade pip and tools as some earlier versions can't install xero-python (even version 1.5.3)
  • changed to specify python 3.9 and higher as anything lower is EOL so really shouldn't include it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant