feat: custom defined MIoT-Spec-V2 instance #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
caibinqing
reviewed
Apr 5, 2025
| return ( | ||
| f'{ha_domain}.{self._model_strs[0][:9]}_{self.did_tag}_' | ||
| f'{self._model_strs[-1][:20]}_s_{siid}') | ||
| f'{self._model_strs[-1][:20]}_s_{siid}_{description}') |
There was a problem hiding this comment.
这里修改了 unique_id ，会生成一个新的实体，并导致用户之前的实体不可用。
如果是有意要修改这个 unique_id 的话，建议可以加一个 migration 步骤帮助用户迁移
（一种可能的方案是 https://developers.home-assistant.io/docs/config_entries_config_flow_handler/#config-entry-migration ）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #946 #41 #35
Added
spec_add.json. xiaomi_home gets the device's MIoT-Spec-V2 from MIoT cloud, then deletes the spercific instances viaspec_filter.yaml, then adds the instances viaspec_add.json, and then modifies the instances viaspec_modify.yaml.