fix: remove redundant hash computation in chunk hash #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSXXSB
reviewed
Dec 3, 2025
| for (char c : str) { | ||
| hash ^= static_cast<uint64_t>(c); | ||
| hash *= 0x01000193; | ||
| class StreamHasher { |
Collaborator
There was a problem hiding this comment.
Place the class definition in the header file.
Author
There was a problem hiding this comment.
Why? This class is not meant to be exposed.
| uint64_t hash_ = 0x811c9dc5; | ||
| }; | ||
|
|
||
| static std::string get_chunk_description(const mtmd_input_chunk* chunk) { |
Collaborator
There was a problem hiding this comment.
Don't want to distinguish whether it's private by removing it from the header file.
Author
There was a problem hiding this comment.
Sorry, I'm not clear on what's this about. Could you please elaborate? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.