Parsing I2C Device ID for MIPI PCAM#1494
Merged
jogomojo merged 1 commit intoXilinx:image_v3.1.1from Aug 7, 2025
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## image_v3.1.1 #1494 +/- ##
=============================================
Coverage 34.98% 34.98%
=============================================
Files 30 30
Lines 4668 4668
Branches 818 818
=============================================
Hits 1633 1633
Misses 2975 2975
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mariodruiz
approved these changes
Aug 6, 2025
| i2c_index = 6 ## legacy | ||
| for dev_path in i2c_devices: | ||
| adapter_number = os.path.basename(dev_path).split('-')[-1] | ||
| name_path = f'/sys/bus/i2c/devices/i2c-{adapter_number}/of_node/label' |
Collaborator
There was a problem hiding this comment.
you could check if the file exists instead of try, but this works as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pcam5c.py used a hardcoded 6 for the /dev/i2c-6 for the PYNQ-ZU and KV260 device. With the addition of the AUP-ZU3 we need a more generic mechanism to lookup the device index. This patch looks for the label "RPICAM" to denote the proper offset.