Fix for CR-1186978 #8273
Merged
Fix for CR-1186978 #8273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aktondak
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
|
Can one of the admins verify this patch? |
AShivangi
requested changes
Jul 8, 2024
src/runtime_src/core/tools/common/tests/TestCmdChainLatency.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Akshay Tondak [email protected]
Signed-off-by: Akshay Tondak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This fixes the issue that an "abort" was thrown by windows when spawning more than 8 processes of xrt-smi simultaneously.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
CR-1186978
How problem was solved, alternative solutions (if any) and why they were rejected
The problem was solved by guarding the opening of hardware context and kernel creation in a try catch block. We do not support more than 8 contexts of hardware and the tool should throw an exception in such cases, instead of an abort from OS.
What has been tested and how, request additional testing if necessary
Tested with the test-case used in the CR. The test-case now fails with tool erroring the following instead of abort:
Test 1 [00c5:00:01.1] : df-bw
Description : Run bandwidth test on data fabric
Xclbin : C:\Windows\System32\DriverStore\FileRepository\ipukmddrv.inf_amd64_d029eeb7affac76f\validate_17f0_10.xclbin
Details : Kernel name is 'DPU_PDI_0'
DPU-Sequence : C:\Windows\System32\DriverStore\FileRepository\ipukmddrv.inf_amd64_d029eeb7affac76f\DPU_Sequence/df_bw.txt
Details : Buffer size: '1'GB
No. of iterations: '600'
Error(s) : Command failed to complete successfully
(ERT_CMD_STATE_ERROR)
Test Status : [FAILED]