[XDP] Changes to support new profile format and update modules offset #8281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
code cleanup
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
jvillarre
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This is an enhancement where user set metric sets are also reported in the profile report and are expanded to valid metric sets at runtime.
Update the AIE Profile offsets to uniquely and easily distinguish between different AIE modules.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
An enhancement in AIE Profile report format.
How problem was solved, alternative solutions (if any) and why they were rejected
An user provided metric sets for aie profile gets expanded into valid metrics sets and mapped to corresponding tiles.
This forms the valid AIE Profile configuration which is being used to report in the new aie profile report.
Further vp_analyzer recognizes this new information based on file version and packs it in protobuf message for Rigel to visualize.
Risks (if any) associated the changes in the commit
Moderate, backward compatibility needs to be re-verified.
What has been tested and how, request additional testing if necessary
Verified on edge vck190
vp_analyze tool now has both report format support.
DSV team have added changes to consider new format to avoid breakages.
Documentation impact (if any)