-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitis 13804 : XRT-SMI re-architecture Patch 1 #8656
Open
aktondak
wants to merge
6
commits into
Xilinx:master
Choose a base branch
from
aktondak:VITIS-13804
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+655
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Can one of the admins verify this patch? |
stsoe
requested changes
Dec 13, 2024
@@ -0,0 +1,194 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright and license.
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
aktondak
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
December 13, 2024 23:09
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR is the first in a series of PRs to follow for https://jira.xilinx.com/browse/VITIS-13804 and xrt-smi re-architecture.
This PR does the following :
What's next ?
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
https://jira.xilinx.com/browse/VITIS-13804 partially
How problem was solved, alternative solutions (if any) and why they were rejected
The problem was solved by coming up with a Json Schema and conforming to that when writing the SUbCmdJsonObjects classes.
Risks (if any) associated the changes in the commit
xrt-smi validate should be tested further since this changes the existing behavior.
What has been tested and how, request additional testing if necessary
Tested xrt-smi validate on windows and Linux platforms.
Documentation impact (if any)
N/A