Skip to content

VITIS-14540 - [MCDM] Provide interface for xrt-smi to disable frame boundary preemption. #8818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zhangchiming
Copy link
Collaborator

Problem solved by the commit
Added the interface to enable/disable frame boundary preemption.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
xrt-smi need a interface to enable/disable frame boundary preemption..

How problem was solved, alternative solutions (if any) and why they were rejected
After this code change, a new escape code will be added to the NPU driver to enable/disable frame boundary preemption.

Risks (if any) associated the changes in the commit
N/A

What has been tested and how, request additional testing if necessary
Tested with the new escape code in NPU driver on Windows 11.

Documentation impact (if any)
N/A

@zhangchiming zhangchiming changed the title Add interface to enable/disable frame boundary preemption. VITIS-14540 - [MCDM] Provide interface for xrt-smi to disable frame boundary preemption. Mar 14, 2025
@zhangchiming zhangchiming requested review from stsoe and removed request for stsoe March 14, 2025 20:29
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Collaborator

@stsoe stsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the clang-tidy warnings. Else everything is good.

Signed-off-by: Chiming <[email protected]>
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@zhangchiming
Copy link
Collaborator Author

Please address the clang-tidy warnings. Else everything is good.

Done.

@zhangchiming zhangchiming requested a review from stsoe March 17, 2025 15:53
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants