Porting pull request 8927 to 2024.2 branch: Fix Alveo HW Emulation seg fault #8960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Villarreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
In Alveo HE-Emulation profiling must destroy its device interface while simulation is still live as the shared_ptrxrt::device used requires a live simulation when it is reclaimed. This was fixed in the master branch with pull request 8937. This is the fix for CR-1240697.
Risks (if any) associated the changes in the commit
Low risk, as this is focused only on Alveo hardware emulation.
What has been tested and how, request additional testing if necessary
The original failing emulation tests have been verified.
Documentation impact (if any)
No documentation impact.