Misc APIs: hipDeviceGetName, hipKernelNameRef. #9097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svup <[email protected]>
svup-xilinx
requested review from
sonals,
chvamshi-xilinx and
stsoe
as code owners
|
svup-xilinx - is not a collaborator |
|
Can one of the admins verify this patch? |
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
requested changes
Jul 28, 2025
Comment on lines
4
to
5
| #include"core/common/device.h" | ||
| #include"core/common/query_requests.h" |
There was a problem hiding this comment.
Suggested change
| #include"core/common/device.h" | |
| #include"core/common/query_requests.h" | |
| #include "core/common/device.h" | |
| #include "core/common/query_requests.h" |
| xrt_core::send_exception_message(ex.what()); | ||
| } | ||
| return nullptr; | ||
| } |
Signed-off-by: svup <[email protected]>
|
svup-xilinx - is not a collaborator |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Implementing hip miscellaneous functions - hipDeviceGetName, hipKernelNameRef.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested on Linux Strix machine
device name is printed as NPU Strix.
kernel name is printed as DPU
used rom_vbnv for printing device name
Documentation impact (if any)
NA