-
Notifications
You must be signed in to change notification settings - Fork 497
[XDP] Support for zocl multi partition for AIE Trace Plugin #9122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
parthash0804
wants to merge
7
commits into
Xilinx:master
Choose a base branch
from
parthash0804:zocl_multi_partition
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+86
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
8830e2d
to
5a2fa02
Compare
clang-tidy review says "All clean, LGTM! 👍" |
IshitaGhosh
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Please remove the CR number.
Signed-off-by: parthash0804 <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Added support for zocl multipartition for AIE Trace Plugin.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
NA
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
Needs more thorough testing for various flow.
What has been tested and how, request additional testing if necessary
Tested ZOCL Multipartition design on VCK190
Tested single parition design on vck190 with register xclbin and load xclbin flow.
Tested independent compilation design for both PLIO and GMIO offload on VCK190.
Tested ML Design on VE2.
Tested Single parition design on Strix
Documentation impact (if any)
NA