-
Notifications
You must be signed in to change notification settings - Fork 497
Cert xrt ini #9133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cert xrt ini #9133
Conversation
Signed-off-by: Brian Xu <[email protected]>
Signed-off-by: Brian Xu <[email protected]>
Signed-off-by: Brian Xu <[email protected]>
Signed-off-by: Brian Xu <[email protected]>
Signed-off-by: Brian Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rbramand-xilinx is making similar changes. He is creating xrt::bo in hw_context constructor & and dumping the it to a file in hw_context destructor. That way, logic to get the logs would be same for All the platforms
ok. that would be better. |
Problem solved by the commit
add entry in xrt.ini controlling cert log buf size and file to save log buf
these entries will be used in shim
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
low
What has been tested and how, request additional testing if necessary
Documentation impact (if any)