Skip to content

Cert xrt ini#9133

Closed
xuhz wants to merge 9 commits intoXilinx:masterfrom
xuhz:cert_xrt_ini
Closed

Cert xrt ini#9133
xuhz wants to merge 9 commits intoXilinx:masterfrom
xuhz:cert_xrt_ini

Conversation

@xuhz
Copy link
Collaborator

@xuhz xuhz commented Aug 6, 2025

Problem solved by the commit

add entry in xrt.ini controlling cert log buf size and file to save log buf
these entries will be used in shim

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

How problem was solved, alternative solutions (if any) and why they were rejected

Risks (if any) associated the changes in the commit

low

What has been tested and how, request additional testing if necessary

Documentation impact (if any)

@xuhz xuhz requested a review from chvamshi-xilinx August 6, 2025 23:11
@xuhz xuhz requested review from rozumx and stsoe as code owners August 6, 2025 23:11
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Collaborator

@chvamshi-xilinx chvamshi-xilinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbramand-xilinx is making similar changes. He is creating xrt::bo in hw_context constructor & and dumping the it to a file in hw_context destructor. That way, logic to get the logs would be same for All the platforms

@xuhz
Copy link
Collaborator Author

xuhz commented Aug 7, 2025

@rbramand-xilinx is making similar changes. He is creating xrt::bo in hw_context constructor & and dumping the it to a file in hw_context destructor. That way, logic to get the logs would be same for All the platforms

ok. that would be better.
linux shim needs to change then

@chvamshi-xilinx
Copy link
Collaborator

We can close this as other PR about log buffer is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants