HIP changes to support full ELF flow #9137
Open
+187
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> only added changes for hipModuleLoad call Signed-off-by: rbramand <[email protected]> Signed-off-by: Rahul Bramandlapalli <[email protected]> Signed-off-by: rbramand <[email protected]>
rbramand-xilinx
requested review from
sonals,
chvamshi-xilinx and
stsoe
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Rahul Bramandlapalli <[email protected]>
|
|
||
| module_xclbin* | ||
| get_xclbin_module() const |
There was a problem hiding this comment.
Do we need this function?
|
|
||
| module_full_elf* | ||
| get_full_elf_module() const | ||
| { |
There was a problem hiding this comment.
Ditto. Do we need this function?
| auto hip_xclbin_mod = std::dynamic_pointer_cast<module_xclbin>(hip_mod); | ||
| throw_invalid_resource_if(!hip_xclbin_mod, "getting hip module using dynamic pointer cast failed"); | ||
| std::shared_ptr<function> hip_func; | ||
| if (hip_mod->is_full_elf_module()) { |
There was a problem hiding this comment.
cant we abstract this logic inside get_function API itself?
|
|
||
| auto hip_elf_mod = std::dynamic_pointer_cast<module_elf>(hip_mod); | ||
| throw_invalid_resource_if(!hip_elf_mod, "getting hip module using dynamic pointer cast failed"); | ||
| if (hip_mod->is_full_elf_module()) { |
There was a problem hiding this comment.
ditto, cant we abstract this inside the class itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Added changes in hip module APIs to load full ELF
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Hip module load calls are modified to try to load full ELF and when exception is caught fallback to load xclbin + elf
Ideal way is to modify hip module calls to load full ELFs but as our compilers at present doesn't generate full ELFs and we need to support xclbin + elf flow for some time the changes are made this way.
Also hipModuleLoadData API only takes void* pointer as input but to create elfio object we need data pointer and size, so added a function to calculate size of elf from elf header.
Risks (if any) associated the changes in the commit
Low as it impacts only HIP flows
What has been tested and how, request additional testing if necessary
Tested existing model test expoi (xclbin + elf) test on strix Linux and it works as expected
Also converted expoi full elf c++ application to HIP based application and tested it on strix Linux, test passes
Documentation impact (if any)
Need to document the usage when HIP documentation is made available