Increase rtl and fifo-depth sim timeouts (fixes #1457)#1458
Merged
auphelia merged 1 commit intoXilinx:devfrom Nov 27, 2025
Merged
Increase rtl and fifo-depth sim timeouts (fixes #1457)#1458auphelia merged 1 commit intoXilinx:devfrom
auphelia merged 1 commit intoXilinx:devfrom
Conversation
Signed-off-by: leah <[email protected]>
Collaborator
|
FYI: We had similar problems but worked around them differently, by letting LIVENESS_THRESHOLD (defaults to 1M) override this heuristic if it is larger: eki-project#115 |
Collaborator
|
Thanks for pointing this out @fpjentzsch. We’ll proceed with @LeahLS's version for now because we want to avoid overriding behavior that we actually want to observe. If we replace the estimation with 1M, we might miss cases where a component changes the cycle count significantly and our estimation becomes too inaccurate. |
Collaborator
|
@auphelia Okay, although I think we should ideally detect mismatches between actual and estimated latency/interval via some kind of is-close comparison in the PyTests or in separate regression tests, not via detecting a simulation timeout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly increased the rtl and fifo-depth simulation timeouts to fix issue #1457 to not run into simulation timeouts when building the upscaled bnn-pynq finn-examples for the AUP-ZU3 board.