Docs and small updates for xrt build infrastructure #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifield
reviewed
Jun 4, 2024
Comment on lines
+1
to
7
| PyYAML>=5.3.1, <=6.0.1 | ||
| aiofiles | ||
| filelock==3.13.1 | ||
| lit | ||
| joblib | ||
| ipykernel | ||
| psutil |
There was a problem hiding this comment.
I've wondered, should we just say to use mlir-aie/python/requirements.txt ?
There was a problem hiding this comment.
I think this makes sense, although I see a con in that it would be an additional undocumented dependency between the two repos. It's possible it could cause some annoyance with maintenance if changes in dependencies/versions in mlir-aie aren't tested for their effects in mlir-air.
If you want me to change it, let me know!
fifield
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
test/xrtto the requirements file.gitignorefile to ignore xrt and python virtual environmentsandboxartifacts