Skip to content

feat: canonicalize Reshape allowzero=1 to Reshape allowzero=0 for certain cases. #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ttjost
Copy link

@ttjost ttjost commented Sep 27, 2024

Conditions:

  • If no value in the 'shape' input is set to zero.

@ttjost ttjost force-pushed the tiagot.canonicalize_reshape_allowzero_to_reshape branch 2 times, most recently from e712f5c to 7068185 Compare September 27, 2024 14:09
@ttjost ttjost disabled auto-merge September 27, 2024 14:10
@ttjost ttjost force-pushed the tiagot.canonicalize_reshape_allowzero_to_reshape branch from 7068185 to 34739b6 Compare September 27, 2024 14:26
@ttjost ttjost requested a review from roberteg16 September 27, 2024 14:27
Copy link

@roberteg16 roberteg16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttjost ttjost enabled auto-merge September 27, 2024 14:44
@ttjost ttjost merged commit cfa4445 into feature/onnx-to-tosa Sep 27, 2024
6 checks passed
@ttjost ttjost deleted the tiagot.canonicalize_reshape_allowzero_to_reshape branch September 27, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants