feat: support disposable dense attribute representations for constants in allowzero reshape canonicalization. #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in allowzero reshape canonicalization.
…nse_int_allowzero_canonicalization
roberteg16
approved these changes
Sep 27, 2024
ttjost
deleted the
tiagot.support_disposable_dense_int_allowzero_canonicalization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also needed for models to work properly. It seems like that we come from ONNX models, and the constant is marked as
initializerthe storage becomesDisposableDense(internal representation in onnx-mlir). So we also need to make sure that this is supported by the canonicalization.Too bad I couldn't figure out how to write a test for this. 😢 . I'll try in another PR.