Skip to content

Fix: ArrayRef assertion failure 'begin <= end' in the FuseAddConvPattern #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2024

Conversation

SamNour
Copy link

@SamNour SamNour commented Oct 16, 2024

This PR fixes the crash Assertion begin <= end' failed in the camo_segmentation_1_3_0_fp32_1x180x320x3 models during MLIR generation .

https://jira.xilinx.com/browse/CR-1208533

@SamNour SamNour requested a review from ttjost October 16, 2024 12:47
@SamNour SamNour self-assigned this Oct 16, 2024
Sam Nour added 2 commits October 17, 2024 15:57
…>::ArrayRef(const T *, const T *) [T = long]: Assertion `begin <= end' failed" in FuseConvAdd pattern

- Added LIT test
@SamNour SamNour requested review from flemairen6 and removed request for ttjost October 18, 2024 13:05
Samnour2 added 3 commits October 18, 2024 14:11
…>::ArrayRef(const T *, const T *) [T = long]: Assertion `begin <= end' failed" in FuseConvAdd pattern

- Added LIT test
Copy link

@flemairen6 flemairen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bit of improvement on testing, otherwise looks fine to me

Sam Nour added 4 commits October 18, 2024 14:20
@SamNour SamNour merged commit 99bb74f into feature/onnx-to-tosa Oct 18, 2024
6 checks passed
@SamNour SamNour deleted the samnour2.CR-1208533.FuseAddAssertionFail branch October 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants