Skip to content

Commit 58823eb

Browse files
committed
Fix javadoc
Signed-off-by: Thomas Farr <[email protected]>
1 parent c2564c9 commit 58823eb

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

java-client/build.gradle.kts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,13 @@ tasks.withType<ProcessResources> {
105105

106106
tasks.withType<Javadoc>().configureEach{
107107
options {
108+
this as StandardJavadocDocletOptions
108109
encoding = "UTF-8"
110+
addMultilineStringsOption("tag").setValue(listOf(
111+
"apiNote:a:API Note:",
112+
"implSpec:a:Implementation Requirements:",
113+
"implNote:a:Implementation Note:",
114+
))
109115
}
110116
}
111117

java-client/src/main/java/org/opensearch/client/transport/aws/AwsSdk2Transport.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,9 @@ public AwsSdk2Transport(
123123
* {@link AwsSdk2TransportOptions#builder()} and use these to specify non-default credentials,
124124
* compression options, etc.
125125
*
126-
* @apiNote Using {@code software.amazon.awssdk.http.apache.ApacheHttpClient} is discouraged as it does not support request bodies on GET or DELETE requests.
127-
* This leads to incorrect handling of requests such as {@link OpenSearchClient#clearScroll(org.opensearch.client.opensearch.core.ClearScrollRequest)} and {@link OpenSearchClient#deletePit(org.opensearch.client.opensearch.core.pit.DeletePitRequest)}.
128-
* As such {@link #performRequest(Object, Endpoint, TransportOptions)} & {@link #performRequestAsync(Object, Endpoint, TransportOptions)} will throw a {@link TransportException} if an unsupported request is encountered while using {@code ApacheHttpClient}.
126+
* @implNote Using {@code software.amazon.awssdk.http.apache.ApacheHttpClient} is discouraged as it does not support request bodies on GET or DELETE requests.
127+
* This leads to incorrect handling of requests such as {@link OpenSearchClient#clearScroll(org.opensearch.client.opensearch.core.ClearScrollRequest)} and {@link OpenSearchClient#deletePit(org.opensearch.client.opensearch.core.pit.DeletePitRequest)}.
128+
* As such {@link #performRequest(Object, Endpoint, TransportOptions)} &amp; {@link #performRequestAsync(Object, Endpoint, TransportOptions)} will throw a {@link TransportException} if an unsupported request is encountered while using {@code ApacheHttpClient}.
129129
*/
130130
public AwsSdk2Transport(
131131
@CheckForNull SdkHttpClient syncHttpClient,
@@ -171,9 +171,9 @@ public AwsSdk2Transport(
171171
* {@link AwsSdk2TransportOptions#builder()} and use these to specify non-default credentials,
172172
* compression options, etc.
173173
*
174-
* @apiNote Using {@code software.amazon.awssdk.http.apache.ApacheHttpClient} is discouraged as it does not support request bodies on GET or DELETE requests.
175-
* This leads to incorrect handling of requests such as {@link OpenSearchClient#clearScroll(org.opensearch.client.opensearch.core.ClearScrollRequest)} and {@link OpenSearchClient#deletePit(org.opensearch.client.opensearch.core.pit.DeletePitRequest)}.
176-
* As such {@link #performRequest(Object, Endpoint, TransportOptions)} & {@link #performRequestAsync(Object, Endpoint, TransportOptions)} will throw a {@link TransportException} if an unsupported request is encountered while using {@code ApacheHttpClient}.
174+
* @implNote Using {@code software.amazon.awssdk.http.apache.ApacheHttpClient} is discouraged as it does not support request bodies on GET or DELETE requests.
175+
* This leads to incorrect handling of requests such as {@link OpenSearchClient#clearScroll(org.opensearch.client.opensearch.core.ClearScrollRequest)} and {@link OpenSearchClient#deletePit(org.opensearch.client.opensearch.core.pit.DeletePitRequest)}.
176+
* As such {@link #performRequest(Object, Endpoint, TransportOptions)} &amp; {@link #performRequestAsync(Object, Endpoint, TransportOptions)} will throw a {@link TransportException} if an unsupported request is encountered while using {@code ApacheHttpClient}.
177177
*/
178178
public AwsSdk2Transport(
179179
@CheckForNull SdkHttpClient syncHttpClient,

0 commit comments

Comments
 (0)