Skip to content

Conversation

@DavidBegert
Copy link
Contributor

Change type:

  • Bug fix
  • Feature
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code and added docstrings to all exposed functions and classes
  • I have made corresponding changes to the documentation
  • Any relevant changes to third party licenses have been updated in the README

@DavidBegert DavidBegert requested a review from timesler October 26, 2020 23:16
Copy link
Contributor

@timesler timesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@klensink
Copy link
Contributor

@DavidBegert is this dead?

@DavidBegert
Copy link
Contributor Author

@klensink Looks done to me. Was it never merged? lol

@klensink
Copy link
Contributor

@DavidBegert Looks like it has merge conflicts that were never resolved. If you add a commit resolving them we can merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants