Renamed the template for nginx config.#158
Open
StuartMacKay wants to merge 1 commit intoYPCrumble:masterfrom
Open
Renamed the template for nginx config.#158StuartMacKay wants to merge 1 commit intoYPCrumble:masterfrom
StuartMacKay wants to merge 1 commit intoYPCrumble:masterfrom
Conversation
Renamed the file used as a template for the nginx configuration for the site
from youtubeadl.j2 to nginx_config.js. Why?
The name follows the convention for other config related templates, e.g.
supervisor_config.j2
It is one less thing to change when adapting the playbook to run with
another project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the file used as a template for the nginx configuration for the site
from youtubeadl.j2 to nginx_config.js. Why?
Apologies for the previous noise. I did not get the upstream changes merged properly.