Review PR #12: STM32F411 support - identified missing bootloader configuration #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed PR #12 adding STM32F411 MCU support. The implementation correctly follows the F401 config pathway with proper specifications (96MHz clock, 512KB flash, 128KB RAM, voltage regulator scaling). Build tests pass for both F411 and F401.
Issue identified: MACH_STM32F411 missing from bootloader offset options in
src/stm32/Kconfig.Required changes
Add
|| MACH_STM32F411to two bootloader configuration lines:Line 315:
Line 324:
Without these, users cannot select bootloader offsets for CanBoot or HID bootloader on F411 boards.
Technical notes
All other changes in PR #12 are correct and follow established F401 patterns.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.