-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webserver.js - allow saml relaystate in POST request #6685
base: master
Are you sure you want to change the base?
Conversation
added check for relaystate saml and regex check
the is lots more RegExp to check, below is the ones ive found you missed
|
added in rest of allowed params
What provider did you use to test relaystate? |
adfs ylian's guide is still pretty good https://ylianst.github.io/MeshCentral/other/adfs_sso_guide/ also |
@nmmclwhitehead ah right ok! |
correct formatting on regex string - now evaluates correctly
@si458 tested the following and can confirm they work (note the viewmode also has to be set to the correct id) |
@nmmclwhitehead thats great! |
this might also fix this old issue too #4882 |
@si458 no problem , whenever you get chance. i guess it could be if you use the /auth-saml url then check for additional query params. then build and set the relaystate not sure if you can use relaystate with OAuth, openid etc |
@si458 okay yeah looks like this can be done with ill have a look ... see what you think after i make the commit :) |
set relaystate on get request
check for ipv6
added relaystate and regex check to prevent redirecting to a page outside of the configured server. also checks for the allowed query params
ref #6272