Move double serverWarnings functionality to common.js

[PTR-inc]

While doing #6695 I saw that there were two 'addServerWarning' functions defined in meshcentral.js. Probably a residue of the app evolution, but thought this could be cleaned up to common.js so it can be called the same way from everywhere.

[si458]

this cannot be merged as its all over the place with the code!

you shouldnt including const common = require('./common.js'); in any of the files
they are passed through using parent.common

also addServerWarning is located the same thing on parent or obj.parent so its located in the meshcentral.js
it should not be moved otherwise it can cause issues

[PTR-inc]

Ah yes, I thought the const common = require('./common.js'); seemed the cleaner way of accessing common functions to me then the parent.common way. There are different ways common.js is referenced throughout the modules, obj.common = require('./common.js'); being another one.

The serverwarning calls aren't called consistently throughout the modules: addServerWarning/obj.addServerWarning (meshcentral.js), parent.addServerWarning (db.js), obj.parent.addServerWarning (webserver.js) and parent.parent.getServerWarnings (meshuser.js), so it was an effort to clean it up a bit.

[PTR-inc]

Oh and there are multiple conflict because of the latest accepted pr's I see.