-
Notifications
You must be signed in to change notification settings - Fork 689
Feature/improve permission handling and management #6891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/improve permission handling and management #6891
Conversation
i think this PR needs splitting up as the is SO MUCH you have changed and is all confusing to following! |
@redneck-f25 Thank you for your contribution. Any chance you could split in distinct PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a typo :)
Why is the schema have the hide RDP default of true?
Where's the default config file that's used during install?
@@ -14524,11 +14535,13 @@ | |||
if ((meshrights & 64) != 0) r.push("Wake Devices"); | |||
if ((meshrights & 128) != 0) r.push("Edit Notes"); | |||
if (((meshrights & 8) != 0) && (meshrights & 256) != 0) r.push("Remote View Only"); | |||
if (((meshrights & 8) != 0) && (meshrights & 4194304) != 0) r.push("Hide RDP Sessionss"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
What is preventing this from being merged? For clearance? |
Resolves #6890
Sorry this PR has a bunch of commits and changed files. While working on the main issue, I found some minor issues... :-)
Changes
"env": { "MESHCENTRAL_DEV_NO_AGENT_SIGNING": "1" }
to launch configuration)domains.ID.desktop.viewonly
applyFeaturePermissionsToRouterAndWebTools
novncargs
novncViewOnlyPort
const MESHRIGHT_HIDERDPSESSIONS = 0x00400000; // 4194304
features3
if (domain.applyfeaturepermissionstorouterandwebtools !== false) {features3 += 0x00000001; }
Dektop | Connect
ifMESHRIGHT_HIDERDPSESSIONS
is setMESHRIGHT_REMOTEVIEWONLY
Limited Input Only
to user featuresdefault{,3}.handlebars
Following the diff of the diffs against 88a765b