Skip to content

nfc: only append Le field in final APDU segment #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

nfc: only append Le field in final APDU segment #864

merged 1 commit into from
Apr 22, 2025

Conversation

ondrej-krc-jediny
Copy link

Fixes some scenarios for PCSC FIDO2 tokens in integrated smartcard readers.
This fix was proposed by @LDVG in #855.

@LDVG
Copy link
Contributor

LDVG commented Apr 9, 2025 •
edited
Loading

Adding some notes for myself and my peers. If anyone out there has other combinations of readers and authenticators we're happy to hear from you.

Tested combinations:

  • T2SR smartcard reader + Token2 T2F2 NFC + PCSC backend (Windows); see linked issue
  • T2SR smartcard reader + Token2 T2F2 CCID + PCSC backend (Windows); see linked issue
  • Integrated Lenovo reader + Token2 CCID + PCSC backend (Windows); see linked issue
  • HID Omnikey 5022CL + YubiKey 5 NFC + PCSC backend (Linux)
  • ACS ACR122U + YubiKey 5 NFC + nfc_linux.c backend

@LDVG LDVG requested a review from kongeo April 22, 2025 09:37
@kongeo kongeo merged commit 69efd88 into Yubico:main Apr 22, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDVG LDVG LDVG approved these changes

@kongeo kongeo kongeo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ondrej-krc-jediny @LDVG @kongeo