Use CMake as build system #349
Conversation
Added call to build-aux/ci/cmake.sh and build-time dependencies.
| include(CTest) | ||
| include(GNUInstallDirs) | ||
|
|
||
| set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake) |
There was a problem hiding this comment.
not really a good idea, so no CMAKE_MODULE_PATH can be supplied from a command line call.
better use list(APPEND
There was a problem hiding this comment.
Hi, @akallabeth .
Thanks for your feedback.
You are technically correct (I've tried), but I don't know why the path should be supplied from command line in the first place. Could you please elaborate on your needs?
There was a problem hiding this comment.
cross compilation or non default locations of dependencies come to mind, so you have (one less) way to provide the appropriate search paths. (the CMAKE_PREFIX_PATH can be used as well)
[edit] not had this issue with pam-u2f yet, but encountered it with other projects
There was a problem hiding this comment.
cross compilation or non default locations of dependencies come to mind, so you have (one less) way to provide the appropriate search paths. (the
CMAKE_PREFIX_PATHcan be used as well) [edit] not had this issue with pam-u2f yet, but encountered it with other projects
I understand. Fixed in #351
This PR is adding a build system based on CMake.
The CMake configuration is added alongside Autoconf/Automake and does not replace it.
Reference issue: #335