Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around cmake bug #356

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Work-around cmake bug #356

merged 1 commit into from
Feb 28, 2025

Conversation

dacav
Copy link
Contributor

@dacav dacav commented Feb 28, 2025

As it turns out, the cmake version shipped with ubuntu 24.04 can not correctly handle ALIAS targets as CMAKE_REQUIRED_LIBRARIES.

We didn't realize before because the ubuntu 24.04 vm available for github actions ships another version of cmake, (3.31.5 instead of 3.28)

@dacav dacav requested a review from LDVG February 28, 2025 15:13
As it turns out, the cmake version shipped with ubuntu 24.04
can not correctly handle ALIAS targets as CMAKE_REQUIRED_LIBRARIES.

We didn't realize before because the ubuntu 24.04 vm available
for github actions ships another version of cmake, (3.31.5 instead of 3.28)
@dacav dacav force-pushed the cmake-fix-ubuntu-2404 branch from 98a15da to 01a52d6 Compare February 28, 2025 19:57
@dacav dacav merged commit 01a52d6 into main Feb 28, 2025
12 of 13 checks passed
@dacav dacav deleted the cmake-fix-ubuntu-2404 branch February 28, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants