pre review fixes

Yubico · Oct 13, 2023 · 47f8fe5 · 47f8fe5
1 parent 2d1c487
commit 47f8fe5
Show file tree

Hide file tree

Showing 5 changed files with 83 additions and 103 deletions.
diff --git a/core/src/main/java/com/yubico/yubikit/core/fido/CtapException.java b/core/src/main/java/com/yubico/yubikit/core/fido/CtapException.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020-2022 Yubico.
+ * Copyright (C) 2020-2023 Yubico.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

diff --git a/fido/src/main/java/com/yubico/yubikit/fido/client/BasicWebAuthnClient.java b/fido/src/main/java/com/yubico/yubikit/fido/client/BasicWebAuthnClient.java
@@ -108,17 +108,16 @@ public BasicWebAuthnClient(Ctap2Session session) throws IOException, CommandExce
             // preference. MUST NOT contain duplicate values nor be empty if present.
             int preferredPinUvAuthProtocol = pinUvAuthProtocols.get(0);
 
-            if (pinSupported && preferredPinUvAuthProtocol == 2) {
+            if (pinSupported && preferredPinUvAuthProtocol == PinUvAuthProtocolV2.VERSION) {
                 this.clientPin = new ClientPin(ctap, new PinUvAuthProtocolV2());
-            } else if (pinSupported && preferredPinUvAuthProtocol == 1) {
+            } else if (pinSupported && preferredPinUvAuthProtocol == PinUvAuthProtocolV1.VERSION) {
                 this.clientPin = new ClientPin(ctap, new PinUvAuthProtocolV1());
             } else {
                 this.clientPin = new ClientPin(ctap, new PinUvAuthDummyProtocol());
             }
         } else {
             this.clientPin = new ClientPin(ctap, new PinUvAuthDummyProtocol());
         }
-
         pinConfigured = pinSupported && clientPin;
 
         Boolean uv = (Boolean) options.get(OPTION_USER_VERIFICATION);

diff --git a/fido/src/main/java/com/yubico/yubikit/fido/client/CredentialManagementSupport.java b/fido/src/main/java/com/yubico/yubikit/fido/client/CredentialManagementSupport.java
diff --git a/fido/src/main/java/com/yubico/yubikit/fido/ctap/Config.java b/fido/src/main/java/com/yubico/yubikit/fido/ctap/Config.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020-2023 Yubico.
+ * Copyright (C) 2023 Yubico.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.