don't unnecessarily copy memory

Yubico · Nov 21, 2023 · 5525a7a · 5525a7a
1 parent bc27e72
commit 5525a7a
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/fido/src/main/java/com/yubico/yubikit/fido/ctap/PinUvAuthProtocolV2.java b/fido/src/main/java/com/yubico/yubikit/fido/ctap/PinUvAuthProtocolV2.java
@@ -117,8 +117,7 @@ public byte[] decrypt(byte[] key, byte[] ciphertext) {
             aesKey = Arrays.copyOfRange(key, 32, key.length);
             byte[] iv = Arrays.copyOf(ciphertext, 16);
             byte[] ct = Arrays.copyOfRange(ciphertext, 16, ciphertext.length);
-            byte[] plaintext = getCipher(Cipher.DECRYPT_MODE, aesKey, iv).doFinal(ct);
-            return Arrays.copyOf(plaintext, plaintext.length);
+            return getCipher(Cipher.DECRYPT_MODE, aesKey, iv).doFinal(ct);
         } catch (BadPaddingException | IllegalBlockSizeException e) {
             throw new IllegalStateException(e);
         } finally {
@@ -139,8 +138,7 @@ public byte[] authenticate(byte[] key, byte[] message) {
         } catch (NoSuchAlgorithmException | InvalidKeyException e) {
             throw new RuntimeException(e);
         }
-        byte[] result = mac.doFinal(message);
-        return Arrays.copyOf(result, result.length);
+        return mac.doFinal(message);
     }
 
     private Cipher getCipher(int mode, byte[] secret, byte[] iv) {