Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpotBugs code scanning #114

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Add SpotBugs code scanning #114

merged 4 commits into from
Dec 19, 2023

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented Dec 19, 2023

This PR is to test whether uploading SARIF files generated by spotbugs applies found vulnerabilities in the Security/Code Scanning GitHub section. (No effect have been seen when this running in branch)

  • SpotBugs related gradle code is moved to project-convention-spotbugs.gradle
  • Produced SARIF files are uploaded to GitHub for analysis
  • Produced HTML files are available to browse locally when using ./gradlew spotbugsMain spotbugsRelease --rerun-tasks

Note: the Fix Sarif step uses jq to update the sarif format to be closer to the GitHub specification but I did not see any effect if required parameters were present or not.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@AdamVe AdamVe merged commit 4cd4ef6 into main Dec 19, 2023
6 checks passed
@AdamVe AdamVe deleted the adamve/spotbugs-reports-v3 branch December 19, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants