Fix MC/GA UserVerificationRequirement.DISCOURAGED #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dainnilsson
reviewed
Jan 18, 2024
fido/src/main/java/com/yubico/yubikit/fido/client/BasicWebAuthnClient.java
Outdated
Show resolved
Hide resolved
fido/src/main/java/com/yubico/yubikit/fido/client/BasicWebAuthnClient.java
Outdated
Show resolved
Hide resolved
fido/src/main/java/com/yubico/yubikit/fido/client/BasicWebAuthnClient.java
Outdated
Show resolved
Hide resolved
dainnilsson
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass correct values of pinUvAuthParam and pinUvAuthProtocol to makeCredential.
Before this fix, we wrongly passed
0pinUvAuthProtocol value instead ofnull.The new integration test verify makeCredential and getAssertion with
nullPIN and UserVerificationRequirement.DISCOURAGED. This way it is possible to create rk = true and rk = false credentials on FIDO2 keys which don't have PIN set. FIDO2 keys with set PIN will return0x36PIN_REQUIRED error.