Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MC/GA UserVerificationRequirement.DISCOURAGED #116

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented Jan 16, 2024

Pass correct values of pinUvAuthParam and pinUvAuthProtocol to makeCredential.

Before this fix, we wrongly passed 0 pinUvAuthProtocol value instead of null.

The new integration test verify makeCredential and getAssertion with null PIN and UserVerificationRequirement.DISCOURAGED. This way it is possible to create rk = true and rk = false credentials on FIDO2 keys which don't have PIN set. FIDO2 keys with set PIN will return 0x36 PIN_REQUIRED error.

@AdamVe AdamVe merged commit a891213 into main Jan 19, 2024
@AdamVe AdamVe deleted the adamve/uv_discouraged branch January 19, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants