Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging_sender.py: permit to choose a matrix chan where to send the notification #2135

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

OniriCorpe
Copy link
Member

@OniriCorpe OniriCorpe commented Mar 15, 2024

The problem

  • Autoupdater pushes it's notifications on yunohost-dev, where it's irrelevant, this notif is for packagers

The solution

  • Permit to choose a matrix channel where to send the notification, so the tool is more versatile and the notifications are pushed to a chan where they're relevant

took inspiration here: https://github.com/YunoHost/webhooks/blob/master/server.py#L34

PR status

not tested
ready to review

@OniriCorpe OniriCorpe force-pushed the matrix-notify-permit-choose-chan branch from c005ec8 to 0bc22b3 Compare March 15, 2024 21:36
tools/appslib/logging_sender.py Show resolved Hide resolved
tools/appslib/logging_sender.py Show resolved Hide resolved
tools/appslib/logging_sender.py Outdated Show resolved Hide resolved
@Salamandar Salamandar force-pushed the matrix-notify-permit-choose-chan branch from 39db5c9 to bddd834 Compare March 18, 2024 22:28
@Salamandar Salamandar merged commit f0870eb into master Mar 18, 2024
5 checks passed
@Salamandar Salamandar deleted the matrix-notify-permit-choose-chan branch March 18, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants