Add SMART status to disk infos #2046
Conversation
christophehenry
force-pushed
the
storage-api-smartctl
branch
from
7e61308 to
9eee442
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| raise NotImplementedError | ||
|
|
||
|
|
||
| class AtaDisk(Disk, AtaController): ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| class AtaDisk(Disk, AtaController): ... | ||
|
|
||
|
|
||
| class NvmeDisk(Disk, NVMeController): ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
christophehenry
force-pushed
the
storage-api-smartctl
branch
3 times, most recently
from
8ee3ff7 to
573daea
Compare
christophehenry
force-pushed
the
storage-api-smartctl
branch
from
573daea to
b3c8fab
Compare
| flags=DbusUnprivilegedFlag, | ||
| ) | ||
| def can_format(self, type: str) -> Tuple[bool, str]: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Have you tried to delete all NotImplemented methods ?
There was a problem hiding this comment.
Those interfaces a automatically generated by the CLI as mentioned at the beginning of the file. The implementation is provided by @dbus_method. The NotImplementerError is just here to have a method content. It could be pass but that's what the CLI generates so I kept it.
|
Thanks for this contrib, i have not tested it yet. Could you explain advantages to use python-sdbus ? Maybe we could try to make pro and cons for the 2 solutions ? We can indeed integrate sdbus in yunohost repo, but it's a things to maintain in more... Is it really needed ? I think it could be nice to create a diagnosis test about smartctl using this... |
|
With sdbus, properties and methods are defined by the generated interfaces. This makes the infos as easy to retrieve as accessing a class property whereas with the dbus-python library you have to unmarshall several layers of dictionary. It makes the code way cleaner and I think it's necessary as I plan to add more features using Udisks2 like formatting, retrieving detailed SMART test results and start new SMAT tests. Now the methods are already defined. Of course, adding python-sdbus is more work but it's already packaged for Debian Trixie and in Bookworm packports. |
christophehenry
force-pushed
the
storage-api-smartctl
branch
2 times, most recently
from
519a2a5 to
a55b895
Compare
christophehenry
force-pushed
the
storage-api-smartctl
branch
2 times, most recently
from
901ce85 to
67c7070
Compare
- Also rewrite API using sdbus-python
christophehenry
force-pushed
the
storage-api-smartctl
branch
from
67c7070 to
4f4e1c1
Compare
| UNKNOWN = enum.auto() | ||
|
|
||
| @staticmethod | ||
| def parse(drive: dict) -> "DiskState": |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
Rel: YunoHost/issues#1823
So this one may be a bit controversial since it rewrite the D-Bus part using
sdbus-pythonwhich is not yet bundled in Debian. I think, however usingsdbus-pythonwill have a positive effect on code since it D-Bus proxies are plain Python classes which improves code expressiveness and API discovery.