-
-
Notifications
You must be signed in to change notification settings - Fork 299
conf_regen: nginx: Remove file left by the bookworm migration. #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
This file was tampering with the logrotate config of nginx. See YunoHost/issues#2549
dde998e
to
cac1fc5
Compare
@@ -857,7 +857,9 @@ | |||
raise NotImplementedError | |||
|
|||
|
|||
class AtaDisk(Disk, AtaController): ... | |||
class AtaDisk(Disk, AtaController): | |||
... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix the issue, we need to determine the intended purpose of the AtaDisk
class. If it is meant to be a concrete class, the ellipsis should be removed, and the class should be left empty (if no additional functionality is required). If the class is meant to be abstract, we should use the abc
module to define it as an abstract class explicitly. For this fix, we will assume the class is concrete and remove the ellipsis.
-
Copy modified line R861
@@ -860,3 +860,3 @@ | ||
class AtaDisk(Disk, AtaController): | ||
... | ||
pass | ||
|
|
||
|
||
class NvmeDisk(Disk, NVMeController): ... | ||
class NvmeDisk(Disk, NVMeController): | ||
... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix the issue, we need to clarify the purpose of the NvmeDisk
class. If it is meant to be an abstract class, we should explicitly declare it as such using the ABC
module from Python's abc
library. If it is meant to be a concrete class, we should implement its functionality or provide a meaningful docstring to explain its purpose.
In this case, we will assume that NvmeDisk
is intended to be an abstract class, as it inherits from Disk
and NVMeController
, which likely define abstract methods. We will:
- Import the
ABC
andabstractmethod
decorators from theabc
module. - Mark the
NvmeDisk
class as inheriting fromABC
. - Add a meaningful docstring to indicate that this class is an abstract base class for NVMe disks.
-
Copy modified line R22 -
Copy modified lines R865-R868
@@ -21,2 +21,3 @@ | ||
from typing import TYPE_CHECKING | ||
from abc import ABC | ||
from unittest.mock import patch | ||
@@ -863,3 +864,6 @@ | ||
|
||
class NvmeDisk(Disk, NVMeController): | ||
class NvmeDisk(Disk, NVMeController, ABC): | ||
""" | ||
Abstract base class for NVMe disks. | ||
""" | ||
... |
This file was tampering with the logrotate config of nginx. See YunoHost/issues#2549
The problem
...
Solution
...
PR Status
...
How to test
...