Redis app resource (implementation alternative)#2124
Open
fflorent wants to merge 7 commits intoYunoHost:devfrom
Open
Redis app resource (implementation alternative)#2124fflorent wants to merge 7 commits intoYunoHost:devfrom
fflorent wants to merge 7 commits intoYunoHost:devfrom
Conversation
fflorent
force-pushed
the
redis-app-resource-alt
branch
from
6c0873e to
52b6a43
Compare
fflorent
changed the title
fflorent
commented
Jun 22, 2025
| f'Uhoh, you seem to have reached the maximum of Redis databases allowed. You may increase the value of "database" in {redis_conf_path} to increase it.', | ||
| raw_msg=True | ||
| ) | ||
| return list(free_dbs)[:count] |
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
See #2122
This PR introduces an alternate implementation (see the latest commit).
Solution
The idea is to let the AppResource store the properties of the previous manifest (the
self.oldproperty). Therefore they could handle the difference, in our case by deprovisionning the redis databases that are removed in the new version.You can check the difference with #2122 here:
fflorent/yunohost@redis-app-resource...fflorent:yunohost:redis-app-resource-alt
PR Status
Need help on these questions
How to test