fix/tools_update: return upgradable apps, not all apps

[kay0u]

The problem

apps contains all the apps installed, not the upgradable ones

Solution

use upgradable_apps instead

PR Status

...

How to test

...

[alexAubin]

Eeeh but that's actually a feature and not a bug (i think ?) because the point was to also list apps that are in special cases such as url_required, possibly because they were in the catalog in the past but are not anymore (otherwise you may never notice it)

Can you elaborate what made you notice this and want to patch it ?

[kay0u]

Edit: It seems that my "fix" doesn't fix my main problem explained bellow
Edit² it does fix it, just need to restart yunohost-api, but as you said, it's intentional, so the problem is elsewhere.
Edit²²Hmm after the reboot, without this patch, I don't have this problem anymore, could it be a browser cache problem?

Can you elaborate what made you notice this and want to patch it ?

Sure, the command sudo yunohost tools update return the list of my installed apps, but maybe that's intentional.

For example:

  33:
    description: Manage passwords and other sensitive informations
    domain_path: my.domain.tld/
    id: vaultwarden
    name: Vaultwarden
    upgrade:
      current_version: 1.34.3~ynh1
      message: Force-upgrading the app (to the same version) can sometimes be useful to rebuild the app and configurations.
      new_revision: d2a91e14c0c1537f286c33d8d6a05c0eb4ebdbc3
      new_version: 1.34.3~ynh1
      requirements: None
      specific_channel: None
      specific_channel_message: None
      status: up_to_date
      url: None
    version: 1.34.3~ynh1

My problem is that, when I navigate to the update page in the web admin, I can see apps that are already up to date.

Before the YNH upgrade (I'm was on testing already), I had the Actual apps to upgrade, I did the YNH upgrade, upgrade Actual, but the app is still tagged as upgradable in the web page.

Actual (actual) de 25.7.1ynh1 à 25.8.0ynh1

But when I check the current version:

# cat /etc/yunohost/apps/actual/manifest.toml | grep version
version = "25.8.0~ynh1"

When i navigate to domain.tld/yunohost/admin/#/apps/actual/_core, I can see the message:

Upgrade

The app can be upgraded from version 25.7.1~ynh1 to 25.8.0~ynh1