Conversation
|
This will break restoration of old backups. |
|
should be mostly good except one thing, how to handle the backup dir because currently we use YNH_CWD to define the destination and as the core backup is called all in one by as a hook we can't set YNH_CWD for each hook. |
Well, normally no because the change try to stay retro compatible. And the original path is saved in the CSV, so at the end in most of case we don't really take care of where we backup. But fee free to bring some improvement in this PR if you have a better idea of how to handle this. |
…idual_script' such that it's actually meaningful ... + trash unused post_callback arg for hook_callback
alexAubin
left a comment
alexAubin
left a comment
There was a problem hiding this comment.
(LGTM modulo how happy the tests are)
Co-authored-by: Alexandre Aubin <4533074+alexAubin@users.noreply.github.com>
|
@alexAubin do you think we could merge it maybe in Trixie ? |
alexAubin
left a comment
alexAubin
left a comment
There was a problem hiding this comment.
I'm gonna say it looks okay to me to merge in current dev but we may get some surprises even though we pretty much carefully reviewed it several times
Any opinion @zamentur @Salamandar ?
4 participants
The problem
We still are using helper v2.0 for hooks
Solution
Use helpers v2.1.
Note I specified the helper version in each file to avoid to upgrade the hook version in case some apps still use helper v2.0 for hooks.
PR Status
Can be tested, seem working
How to test
Run the regen-conf, backup, restore