Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix data descriptor handling #338

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix data descriptor handling #338

wants to merge 2 commits into from

Conversation

itsuki-takatsuno
Copy link

@itsuki-takatsuno itsuki-takatsuno commented Aug 28, 2024 •
edited
Loading

Why am I submitting this PR

Fixed a bug that caused Parse to fail when there is a zip in the zip, the zip has PK78, and the file in the zip also has PK78.

ToDo

  • Implement a fix to address the bug mentioned above.
  • Add support for ZIP64 format handling (since compressedSize is represented in 8 bytes).
  • Write tests to ensure the fix and the ZIP64 handling work as expected.

@itsuki-takatsuno itsuki-takatsuno marked this pull request as draft August 28, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsuki-takatsuno @LunaInsidious