Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the en-US i18n strings related to Rclone update notifications/status, likely reflecting a revised “download vs install” flow.
Changes:
- Removes
modals.about.updatingfrom the en-US base strings. - Updates
notification.*.rcloneUpdateCompletewording to indicate the update was downloaded (not installed). - Adds new
notification.*.rcloneUpdateInstalledstrings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "rcloneUpdateAvailable": "Rclone Update Available", | ||
| "whatsNewRclone": "What's New in Rclone", | ||
| "updating": "Updating...", | ||
| "updateRclone": "Download Rclone Update", |
There was a problem hiding this comment.
modals.about.updating was removed from the en-US base strings, but the frontend template still references it (see about-modal.component.html around the rclone update button). This will display a missing-translation key for en-US (likely the default language). Re-add this key (or update the template to use an existing key like modals.about.downloading/rcloneUpdateStarted).
Suggested change
| "updateRclone": "Download Rclone Update", | |
| "updateRclone": "Download Rclone Update", | |
| "updating": "Updating Rclone...", |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.