Skip to content

Commit

Permalink
fix(deploy): use correct principalSet instead of SA
Browse files Browse the repository at this point in the history
  • Loading branch information
gustavovalverde committed Jul 15, 2024
1 parent c1d21c9 commit a0877f6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/chore-clean-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
uses: google-github-actions/[email protected]
with:
workload_identity_provider: '${{ vars.GCP_WIF }}'
service_account: '${{ vars.GCP_DEPLOYMENTS_SA }}'
project_id: '${{ vars.GCP_PROJECT }}'

- name: Set up Cloud SDK
uses: google-github-actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sub-build-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
uses: google-github-actions/[email protected]
with:
workload_identity_provider: '${{ vars.GCP_WIF }}'
service_account: '${{ vars.GCP_ARTIFACTS_SA }}'
project_id: '${{ vars.GCP_PROJECT }}'
token_format: 'access_token'
# Some builds might take over an hour, and Google's default lifetime duration for
# an access token is 1 hour (3600s). We increase this to 3 hours (10800s)
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/sub-cloudrun-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
type: string
description: The image digest to deploy
project_id:
required: true
required: false
type: string
description: The project to deploy to
region:
Expand Down Expand Up @@ -77,12 +77,16 @@ jobs:
- name: Inject slug/short variables
uses: rlespinasse/[email protected]

- uses: actions/[email protected]
with:
persist-credentials: false

- name: Authenticate to Google Cloud
id: auth
uses: google-github-actions/[email protected]
with:
workload_identity_provider: '${{ vars.GCP_WIF }}'
service_account: '${{ vars.GCP_DEPLOYMENTS_SA }}'
project_id: '${{ vars.GCP_PROJECT }}'

- name: Set up Cloud SDK
uses: google-github-actions/[email protected]
Expand Down

0 comments on commit a0877f6

Please sign in to comment.