-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependencies by switching to simplified API with a callback interface #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
conradoplg
force-pushed
the
simplify-api
branch
2 times, most recently
from
May 27, 2024 23:19
a15dd7d
to
8e226cc
Compare
conradoplg
commented
May 29, 2024
conradoplg
changed the title
Simplify API with callback interface
Remove all dependencies with simplified API with callback interface
May 29, 2024
conradoplg
changed the title
Remove all dependencies with simplified API with callback interface
Remove all dependencies with simplified API using callback interface
May 29, 2024
conradoplg
changed the title
Remove all dependencies with simplified API using callback interface
Remove most dependencies with simplified API using callback interface
May 29, 2024
conradoplg
changed the title
Remove most dependencies with simplified API using callback interface
Remove dependencies by switching to simplified API with a callback interface
May 29, 2024
upbqdn
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zcash_script links in zcashd source code, and since the API takes a
CTransaction
that requires include a bunch of other stuff like orchard, etc.This simplifies the API, by not passing the entire transaction but only the data required to verify. This makes this crate have ZERO Rust dependencies 🎉
This requires using a callback to compute the sighash, since to compute it you need some information that is extracted with zcash_script.cpp.
This approach does not decrease performance because it still allows the use of precomputation in the sighash: simply precompute and store in the
ctx
pointer, which will be forwarded to the sighash callback and can be used in the sighash computation by the caller.