Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Rustier wrapper for zcash_script #171

Merged
merged 7 commits into from
Sep 17, 2024

Commits on Aug 12, 2024

  1. Move C++ bindings out of lib.rs

    Have lib.rs re-export them, but make room for the upcoming Rust implementation.
    sellout committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    59642ca View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Provide a Rustier wrapper for zcash_script

    This adds a `Script` trait that exposes slightly Rustier types in order
    to have a common interface for the existing C++ implementation as well
    as the upcoming Rust implementation (and a third instance that runs both
    and checks that the Rust result matches the C++ one).
    
    The module structure (interpreter.rs, zcash_script.rs) and locations of
    definitions are intended to mirror the structure of the C++ code, especially as
    we get the Rust implementation in place, for easier comparison. That
    organization is very likely to change once everything has been checked.
    sellout committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b55a7f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Address review feedback

    Thanks to @nuttycom and @arya2 for getting the closure to work.
    sellout committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c6ff3fc View commit details
    Browse the repository at this point in the history
  2. Additional cleanup

    sellout committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    52927c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f526f69 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Address review feedback

    sellout committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    eca9469 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Widen the Unknown error type

    This should fix the Windows build.
    sellout committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f16ce84 View commit details
    Browse the repository at this point in the history