Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display Perfect result in Session Recap and BGs Replays Recap #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piedpiper358
Copy link
Contributor

Before:

2022-09-10_13-04-18

After:

2022-09-10_13-16-58

Before:

2022-09-08_19-03-07

After:

2022-09-08_21-09-05

@sebastientromp
Copy link
Contributor

I would like to keep the "Perfect!" label. If it causes issues because of the size, we can maybe just change the label ( "Prft!" might work, or anything to show that this was a perfect run).
Adding an icon is possible as well.

@piedpiper358
Copy link
Contributor Author

What exactly does the "Perfect" run mean?

@sebastientromp
Copy link
Contributor

You won without losing any health (that was before the Armor got introduced, so maybe now it should also take this into account)

@piedpiper358
Copy link
Contributor Author

Probably yes, because I had a run in which I lost twice, but nevertheless it is marked as Perfect.

@piedpiper358
Copy link
Contributor Author

@sebastientromp, How do you feel about using this icon for perfect results?

images (3) 2

@piedpiper358 piedpiper358 removed their assignment Nov 14, 2022
@sebastientromp
Copy link
Contributor

Yes that would work. Probably even better than showing a "Perfect" label, as it would visually set it apart (we'll just need a tooltip on the icon to explain what it means)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants