Disable ability revealing during battle #289
Conversation
| @@ -27,7 +27,7 @@ export class MercenariesAbilityRevealedParser implements MercenariesParser { | |||
| const isPlayer = controllerId === localPlayer.PlayerId; | |||
| const team = isPlayer ? battleState.playerTeam : battleState.opponentTeam; | |||
| const abilityOwner = team.getMercenary(ownerEntityId); | |||
| if (!cardId) { | |||
| if (!cardId || battleState.currentTurn!=0) { | |||
There was a problem hiding this comment.
I'm not totally sure about this change. When an ability swap from one to another (which is not yet supported), we might have to handle it in this parser (along with an "ability_hidden" event maybe).
Also, why hide abilities revealed during the fight in the first place? I'm not too familiar with this use case, why aren't they valid?
There was a problem hiding this comment.
When a mercenary's ability swap from one to another, neither the MERCENARIES_ABILITY_REVEALED nor "ability_hidden" event occurs.
A mercenary cannot gain new abilities during battle. MERCENARIES_ABILITY_REVEALED event occurs in-combat when an ability with a select effect is triggered (and this effect card is added to that mercenary's abilities) or if the ability was cast from some treasure such as Prideful Wish or Arcane/Shadow/Fireball/Frost/Fel/Light Volley. But the player can't actually use this mercenary ability, so it shouldn't show up.
(See Tess' ability list, it contains 7 abilities cast by Prideful Wish)
sebastientromp
force-pushed
the
master
branch
from
07b0da7 to
fe6d979
Compare
sebastientromp
force-pushed
the
master
branch
3 times, most recently
from
159c76c to
ef452e5
Compare
Before:
After: