Multicore aware semaphore for rp2xxx #444
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Should this go into This is probably worth discussing more on discord, if you're not already on there I'd ask you join. |
|
I joined the discord group. Also made some changes to integrate with enter_critical_section. |
|
Same errors here as the other PR. I don't think it's something I did as other PRs are getting them too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current critical section code in microzig.intterrupt only disables interrupts, it does not block code running on another core from altering protected resources.
This code attempt to address this by both blocking interrupts and providing a mechanism to block other cores from entering.