Skip to content

esp: gpio: Convert pin to enum #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

esp: gpio: Convert pin to enum #487

merged 3 commits into from
Apr 22, 2025

Conversation

Grazfather
Copy link
Collaborator

  • Convert esp Pin from a struct to an enum (to match rp2xxx)
  • Add num function to grab pin (also to match rp2xxx)

@Grazfather Grazfather requested a review from tact1m4n3 April 22, 2025 14:45
tact1m4n3
tact1m4n3 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@tact1m4n3 tact1m4n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about removing gpio.instance? I feel like it's redundant. Most people would just use gpio.num.

tact1m4n3
tact1m4n3 reviewed Apr 22, 2025
View reviewed changes
tact1m4n3
tact1m4n3 reviewed Apr 22, 2025
View reviewed changes
@Grazfather Grazfather merged commit 7aad8aa into main Apr 22, 2025
41 checks passed
@Grazfather Grazfather deleted the esp_pin_num branch April 22, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tact1m4n3 tact1m4n3 tact1m4n3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Grazfather @tact1m4n3